Skip to content

refactor: convert dash-case inputs to camelCase #2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 17, 2016
Merged

refactor: convert dash-case inputs to camelCase #2244

merged 8 commits into from
Dec 17, 2016

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 15, 2016 •
edited
Loading

Converts any dash-cased @Input properties into camelCase and adds a deprecated proxy property with the old naming. The following properties have been renamed:

  • md-ripple-trigger
  • md-ripple-centered
  • md-ripple-disabled
  • md-ripple-max-radius
  • md-ripple-speed-factor
  • md-ripple-color
  • md-ripple-background-color
  • md-ripple-focused
  • md-ripple-unbounded
  • thumb-label
  • tick-interval
  • md-dynamic-height
  • tooltip-position

The following properties were skipped:

  • md-menu-trigger-for - Is currently used also as a selector for the menu trigger.
  • Any properties that have a native equivalent (e.g. aria-label, aria-labeledby).

@crisbeto crisbeto requested a review from jelbourn December 15, 2016 22:29
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 15, 2016
@jelbourn
Copy link
Member

@crisbeto I just now finished a long debate chat with Misko and Igor, the outcome of which is that @Directive properties should also be prefixed. (and @Component properties are not). Based on that, could you also change:

  • md-dynamic-height to just dynamicHeight
  • tooltipPosition to mdTooltipPosition
  • tooltipShowDelay to mdTooltipShowDelay
  • tooltipHideDelay to mdTooltipHideDelay
  • md-tooltip to mdTooltip (adding mdTooltip to the existing selector)
  • md-menu-trigger-for to mdMenuTriggerFor (adding mdMenuTriggerFor to the existing selector)

@jelbourn
Copy link
Member

Also wanted to make sure I mentioned: properties themselves don't have to have an md prefix. For example, we can still have

@Input('mdTooltipPosition')
position: TooltipPosition;

@fxck
Copy link
Contributor

fxck commented Dec 16, 2016 •
edited
Loading

isn't renaming @Input()s another thing styleguide advise against?

@jelbourn
Copy link
Member

@fxck we may be revisiting that particular piece of advice. Much of the style guide was written speculatively.

@crisbeto
Copy link
Member Author

Applied the feedback and rebased @jelbourn.

@jelbourn
Copy link
Member

LGTM, awesome

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 16, 2016
jelbourn
jelbourn reviewed Dec 16, 2016
View reviewed changes
src/lib/tabs/tab-group.ts
@@ -48,6 +48,9 @@ export class MdTabChangeEvent {
selector: 'md-tab-group',
templateUrl: 'tab-group.html',
styleUrls: ['tab-group.css'],
host: {
'[class.md-tab-group-dynamic-height]': '_dynamicHeight'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google presubmit caught that this is private; should just be dynamicHeight

@crisbeto
refactor: convert dash-case inputs to camelCase
7687114 
Converts any dash-cased `@Input` properties into camelCase and adds a deprecated proxy property with the old naming. The following properties have been renamed:

* `md-ripple-trigger`
* `md-ripple-centered`
* `md-ripple-disabled`
* `md-ripple-max-radius`
* `md-ripple-speed-factor`
* `md-ripple-color`
* `md-ripple-background-color`
* `md-ripple-focused`
* `md-ripple-unbounded`
* `thumb-label`
* `tick-interval`
* `md-dynamic-height`
* `tooltip-position`

The following properties were skipped:
* `md-menu-trigger-for` - Is currently used also as a selector for the menu trigger.
* Any properties that a native equivalent (e.g. `aria-label`, `aria-labeledby`).
@crisbeto
Fix tabs CSS issue and switch mdDynamicHeight to dynamicHeight.
ec5cbb1
@crisbeto
Rename [md-tooltip] to [mdTooltip].
1d4dceb
@crisbeto
Rename md-menu-trigger-for to mdMenuTriggerFor.
a4675e6
@crisbeto
Use public property for dynamic height binding.
fb5abcd
@jelbourn jelbourn merged commit 3637b93 into angular:master Dec 17, 2016
crisbeto added a commit to crisbeto/material2 that referenced this pull request Dec 22, 2016
@crisbeto
fix(ripple): camel-cased CSS properties
448a156 
A few CSS classes got camel cased, by accident, as a part of angular#2244.
@crisbeto crisbeto mentioned this pull request Dec 22, 2016
Merged
crisbeto added a commit to crisbeto/material2 that referenced this pull request Dec 22, 2016
@crisbeto
fix(ripple): camel-cased CSS classes
4e42b13 
A few CSS classes got camel cased, by accident, as a part of angular#2244.
@crisbeto crisbeto mentioned this pull request Dec 27, 2016
Closed
crisbeto added a commit to crisbeto/material2 that referenced this pull request Dec 30, 2016
@crisbeto
fix(ripple): camel-cased CSS classes
584b097 
A few CSS classes got camel cased, by accident, as a part of angular#2244.
@devversion devversion mentioned this pull request Jan 3, 2017
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn left review comments

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @fxck @googlebot